Version conflicts #2735
Merged
Version conflicts #2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottoneil-ms
requested review from
michaelcfanning,
EasyRhinoMSFT,
marmegh and
cfaucon
as code owners
scottoneil-ms
requested review from
suvamM,
shaopeng-gh,
rwoll,
yongyan-gh and
LingZhou-gh
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like I never opened this PR. It is intended to clear up build warnings and especially version conflict issues at the sarif-sdk level. A lot of this change is removing extraneous references. Since everything is working well at the consumer level, it looks like this work isn't strictly necessary to get to clean there (I worked this change in the same enlistment so it wasn't clear as I was working if they were severable.) However, I think we should definitely want to take this one especially to get the change that turns on warnings as errors for assembly conflict issues.